Skip to content

Factor out Hypervisor compute-service enabling/disabling to own controller - #328

Draft
fwiesel wants to merge 1 commit into
mainfrom
factor-out-hypervisor-disabled
Draft

fwiesel wants to merge 1 commit into
mainfrom
factor-out-hypervisor-disabled

Conversation

@fwiesel

@fwiesel fwiesel commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Extracts the Nova compute-service enable/disable logic from HypervisorMaintenanceController into a dedicated HypervisorComputeServiceController. This separates the concerns of HA-state management (maintenance) from compute-service lifecycle.

Includes full unit tests for the new controller.

Depends on: ssa (#327).

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 415e66bc-8c25-4f4a-a69f-1dff1bbe52fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch factor-out-hypervisor-disabled

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fwiesel
fwiesel force-pushed the ssa branch 2 times, most recently from 4c09880 to 9d785cb Compare July 9, 2026 17:56
@fwiesel
fwiesel force-pushed the factor-out-hypervisor-disabled branch 2 times, most recently from 6b3ca9d to 8a3eb91 Compare July 9, 2026 18:34
@fwiesel
fwiesel force-pushed the factor-out-hypervisor-disabled branch from 8a3eb91 to a3646df Compare July 13, 2026 12:18
@fwiesel
fwiesel force-pushed the ssa branch 2 times, most recently from b2fd489 to ad93c0b Compare July 13, 2026 19:59
Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
@fwiesel
fwiesel changed the base branch from ssa to main November 13, 2026 20:48
@fwiesel
fwiesel force-pushed the factor-out-hypervisor-disabled branch from a3646df to 073f51a Compare November 13, 2026 20:48
@github-actions

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 74.92% (-0.51%) 👎
Coverage details

Compared to commit cfee313 (run #43438290245)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/cmd/main.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_compute_service_controller.go 81.03% (+81.03%) 58 (+58) 47 (+47) 11 (+11) 🌟
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller.go 86.32% (-2.86%) 117 (-31) 101 (-31) 16 👎
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller.go 65.17% (-0.11%) 267 (+2) 174 (+1) 93 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_compute_service_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant